Re: BUG #19774: Incremental backup loses re-extended blocks when WAL summaries are merged out of LSN order

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: Ayush Tiwari <ayushtiwari(dot)slg01(at)gmail(dot)com>
Cc: kehan5800(at)gmail(dot)com, pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: BUG #19774: Incremental backup loses re-extended blocks when WAL summaries are merged out of LSN order
Date: 2026-10-22 08:48:30
Message-ID: CAHGQGwEgRsr4n-U0hnSEN8gsxeb4FzLgS-NDRXNffYVy96udag@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On Wed, Oct 21, 2026 at 7:04 PM Ayush Tiwari
<ayushtiwari(dot)slg01(at)gmail(dot)com> wrote:
> Would it make sense for FilterWalSummaries() to use the same >= / <=
> checks as GetWalSummaries()?

I haven't looked into this in detail, but your point sounds valid.
Since this seems to be a separate issue, I think it should be addressed
in a separate patch.

> The patch looks good to me though.

Thanks for the review! Barring any objections, I will commit v1-0001 patch.

Regards,

--
Fujii Masao

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message Zhijie Hou 2026-10-22 08:53:41 Re: BUG #19760: CLUSTER loses a row the transaction inserted and then updated in a rolled-back subtransaction
Previous Message Fujii Masao 2026-10-22 08:37:50 Re: START_REPLICATION silently truncates an overlong LSN component