| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | furuyao(at)pm(dot)nttdata(dot)co(dot)jp |
| Cc: | Andres Freund <andres(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, teranishih(at)nttdata(dot)co(dot)jp |
| Subject: | Re: pg_receivexlog add synchronous mode |
| Date: | 2014-08-05 12:04:51 |
| Message-ID: | CAHGQGwEeQR=P1OPX5mgEpYhbWgVHeBz+ytH4-n7V2eaJx7qorg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jul 29, 2014 at 7:07 PM, <furuyao(at)pm(dot)nttdata(dot)co(dot)jp> wrote:
> I have improved the patch by making following changes:
>
> 1. Since stream_stop() was redundant, stream_stop() at the time of WAL file closing was deleted.
>
> 2. Change the Flash judging timing for the readability of source code.
> I have changed the Flash judging timing , from the continuous message after receiving to
> before the feedbackmassege decision of continue statement after execution.
Thanks for the updated version of the patch!
While reviewing the patch, I found that HandleCopyStream() is still
long and which decreases the readability of the source code.
So I feel inclined to refactor the HandleCopyStream() more for better
readability. What about the attached refactoring patch?
Regards,
--
Fujii Masao
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2014-08-05 12:06:51 | Re: pg_receivexlog add synchronous mode |
| Previous Message | Fujii Masao | 2014-08-05 11:31:23 | Re: psql: show only failed queries |