| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Stabilize recovery conflict stats checks in 031_recovery_conflict.pl |
| Date: | 2026-09-03 04:19:30 |
| Message-ID: | CAHGQGwEBuHZnPgWKFf6FJYFX=h+f6aS6VGtToeBLgJL--AfgJw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Sep 2, 2026 at 5:57 PM Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com> wrote:
> I confirm that your patch fixes the problem and LGTM.
Thanks Ayush and Nazir, for the test and review! I've pushed the patch.
> I attached a patch for fixing this problem by using poll_query_until()
> like you did. I am not sure if 'test_custom_stats/001_custom_stats' is
> the real problem since you need quite a big sleep time to reproduce
> it, but I wanted to mention it just in case.
As you mentioned, this doesn't seem to be causing any actual buildfarm or
CI failures at the moment. So I'm inclined to leave things as they are
and not apply the patch....
Of course, if many others think it's better to apply it proactively,
I'm ok with that, though.
Regards,
--
Fujii Masao
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ewan Young | 2026-09-03 04:19:49 | FOR PORTION OF silently ignored on views with DO INSTEAD rules |
| Previous Message | Michael Paquier | 2026-09-03 04:08:27 | Re: Use WALReadFromBuffers in more places |