| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | vignesh C <vignesh21(at)gmail(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Tristan Partin <tristan(at)partin(dot)io>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Fix publisher-side sequence permission reporting |
| Date: | 2026-06-26 07:04:21 |
| Message-ID: | CAHGQGwE9AOvhqPOx7J=zPug5s90FhNVPH8m0m3AVJVzjG8npBQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jun 24, 2026 at 7:49 PM vignesh C <vignesh21(at)gmail(dot)com> wrote:
> Thanks for the patch. I verified that it fixes the issue with reading
> unlogged sequences on a promoted standby.
Thanks for testing!
> Do you think it would be worthwhile to add a test for this scenario,
> or do you feel the additional test is not necessary in this case?
I think it's worth adding a test for this scenario, so I've added one to
the patch. The test uses nextval() to read the unlogged sequence
instead of pg_get_sequence_data(), since this patch needs to be
backpatched to v15, while pg_get_sequence_data() was introduced in
v19.
Attached are updated patches for master and the stable branches.
Regards,
--
Fujii Masao
| Attachment | Content-Type | Size |
|---|---|---|
| v2-v15-0001-Fix-unlogged-sequence-corruption-after-standby-pr.txt | text/plain | 8.3 KB |
| v2-0001-Fix-unlogged-sequence-corruption-after-standby-pr.patch | application/octet-stream | 8.7 KB |
| v2-v18-v17-0001-Fix-unlogged-sequence-corruption-after-standby-pr.txt | text/plain | 8.7 KB |
| v2-v16-0001-Fix-unlogged-sequence-corruption-after-standby-pr.txt | text/plain | 8.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2026-06-26 07:13:50 | Re: Proposal: Conflict log history table for Logical Replication |
| Previous Message | Nitin Jadhav | 2026-06-26 06:59:38 | Re: Change checkpoint‑record‑missing PANIC to FATAL |