| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)kurilemu(dot)de> |
| Cc: | Radim Marek <radim(at)boringsql(dot)com>, Antonin Houska <ah(at)cybertec(dot)at>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: REPACK (CONCURRENTLY) might keep dropped-column data |
| Date: | 2026-10-06 02:50:04 |
| Message-ID: | CAHGQGwE7bE944nqv4VnwSq9GFYs-4bz203+3BNTKqybYVDTe8Q@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Oct 5, 2026 at 8:35 PM Alvaro Herrera <alvherre(at)kurilemu(dot)de> wrote:
> I think the repeated creating/dropping is a bit wasteful though and we
> don't need it. Wouldn't it make more sense to have all tests use CREATE
> IF NOT EXISTS and then remove all the DROPs of it? We would end up
> having the extension after the tests are run, but since the database is
> specifically created to run the isolation tests, it's not a problem if
> it remains there. The attached patch would do that. (I am proposing
> this change just for pg20.)
+1
-# A foreign key check racing a rebuild of the index it resolves through.
#
# Pause the RI fast path before it locks the referenced table, allowing
Removing the first line of the comment seems unnecessary?
Regards,
--
Fujii Masao
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Hayato Kuroda (Fujitsu) | 2026-10-06 02:56:17 | RE: Fix apply worker crash when subscriber table has only a deferrable primary key |
| Previous Message | shihao zhong | 2026-10-06 02:36:15 | Re: [PG19] eager aggregation gives wrong results because of bpchar_ops |