Re: pgsql: Silence compiler warning about pointer type mismatch on some pla

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Silence compiler warning about pointer type mismatch on some pla
Date: 2012-10-02 16:33:58
Message-ID: CAHGQGwE6nS7jise-0hSyt4GT2a6ngtpc9gzssr9nHxDvKiYGvQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Tue, Oct 2, 2012 at 11:47 PM, Heikki Linnakangas
<heikki(dot)linnakangas(at)iki(dot)fi> wrote:
> Silence compiler warning about pointer type mismatch on some platforms.
>
> timeval.t_sec is of type time_t, which is not always compatible with long.
> I'm not sure if this was just harmless warning or a real bug, but this
> fixes it, anyway.

+ timeout.tv_sec = usecs;

This code looks like a bug. No? I think the attached patch should be applied.

Regards,

--
Fujii Masao

Attachment Content-Type Size
receivelog-bugfix_v1.patch application/octet-stream 559 bytes

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Heikki Linnakangas 2012-10-02 17:00:50 pgsql: Fix typo in previous warning-silencing patch.
Previous Message Peter Geoghegan 2012-10-02 16:05:49 Re: pgsql: Disable _FORTIFY_SOURCE with ICC