| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | Ian Lawrence Barwick <barwick(at)gmail(dot)com> |
| Cc: | Daniel Gustafsson <daniel(at)yesql(dot)se>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pg_control_checkpoint(): add "data_checksum_version" (Pg19)? |
| Date: | 2026-08-10 13:30:19 |
| Message-ID: | CAHGQGwE3t5J8ic9N_2CFqwDxrEXAfz4aPeH0P0U3MqYquP4Ppg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Aug 10, 2026 at 9:39 PM Ian Lawrence Barwick <barwick(at)gmail(dot)com> wrote:
> The function "get_checksum_state_string()" which performs the conversion is in
> src/backend/access/rmgrdesc/xlogdesc.c, which AFAIR can't be linked from
> frontend utilities, so we'd either have to move that somewhere else (maybe
> src/common/controldata_utils.c?) or duplicate it.
Agreed. I think moving it to common is better than duplicating the mapping.
src/common/controldata_utils.c seems like a reasonable place, since
this state is stored in the control/checkpoint data and both pg_controldata
and pg_control_checkpoint() already use controldata_utils.
Regards,
--
Fujii Masao
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andreas Karlsson | 2026-08-10 13:36:29 | Re: [RFC PATCH v3 0/7] Umbra: a remap-aware smgr prototype |
| Previous Message | Dilip Kumar | 2026-08-10 13:15:15 | Re: Proposal: Conflict log history table for Logical Replication |