| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | Raja Sai pranav <rajasaipranav0(at)gmail(dot)com> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org, robertmhaas(at)gmail(dot)com |
| Subject: | Re: [PATCH] doc: Fix pg_combinebackup's description of --sync-method |
| Date: | 2026-11-05 00:03:45 |
| Message-ID: | CAHGQGwE=44aB8-H+jLPKNSbGRZsARSGZN0QDAE1BjGEmZRbWvQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Nov 5, 2026 at 2:43 AM Raja Sai pranav <rajasaipranav0(at)gmail(dot)com> wrote:
> The --sync-method entry on the pg_combinebackup reference page was copied from pg_basebackup and still says "When the plain format is used" twice
Thanks for the report and patch! LGTM. Barring any objections, I'll commit it.
BTW, I also wonder if the following description in the Environment section was
copied from elsewhere and is incorrect. AFAIK, pg_combinebackup neither uses
nor links against libpq. Should we remove it? Or am I missing something?
This utility, like most other PostgreSQL utilities, uses the environment
variables supported by libpq (see Section 32.14).
Regards,
--
Fujii Masao
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Lukas Fittl | 2026-11-05 00:10:08 | Re: Fix cumulative WAL statistics double-counting from parallel workers |
| Previous Message | Peter Smith | 2026-11-04 23:47:23 | Re: BUG? Unpublished generated columns are reported "missing" by the subscription |