| From: | solaimurugan vellaipandiyan <drsolaimurugan(dot)v(at)gmail(dot)com> |
|---|---|
| To: | Payal Singh <payals1(at)umbc(dot)edu> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Review - Patch for pg_bsd_indent: improve formatting of multiline comments |
| Date: | 2026-05-10 13:59:53 |
| Message-ID: | CAHEL7KRa-rmSCvREEYrdsY97PNgJtqLYfOikfZWEK4enNQhM0Q@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Aleksander,
I tested v7 of the patch on current HEAD.
The patch applied cleanly and multiline comments were reformatted
correctly in my testing. I also verified that repeated pgindent runs
did not produce additional changes, and git diff --check was clean.
While testing some real PostgreSQL source files, I noticed
banner-style comments in contrib/seg/seg.c still receive formatting
changes like:
- This file contains routines ...
+ * This file contains routines ...
This looks similar to the earlier discussion around separator-style
comments and possible unnecessary diff churn. Since these header
comments already appear visually structured, perhaps preserving them
could help reduce additional formatting noise.
Apart from that observation, the patch looked good overall in my testing.
Regards,
solai murugan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | ChenhuiMo | 2026-05-10 14:12:15 | [PATCH] Make NumericVar storage semantics explicit |
| Previous Message | Andrew Dunstan | 2026-05-10 12:53:17 | Re: Fix wrong error message from pg_get_tablespace_ddl() |