Re: proposal: pg_restore --convert-to-text

From: Euler Taveira <euler(at)timbira(dot)com(dot)br>
To: "Imai, Yoshikazu" <imai(dot)yoshikazu(at)jp(dot)fujitsu(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andreas Karlsson <andreas(at)proxel(dot)se>, Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: proposal: pg_restore --convert-to-text
Date: 2019-03-16 22:54:30
Message-ID: CAHE3wgjr9ADdVBhZM+ZBBzdapzHmCBTpYXpKNVLv1u2iw-Nv3A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Em qua, 27 de fev de 2019 às 23:48, Imai, Yoshikazu
<imai(dot)yoshikazu(at)jp(dot)fujitsu(dot)com> escreveu:
>
> Is there no need to rewrite the Description in the Doc to state we should specify either -d or -f option?
> (and also it might be better to write if -l option is given, neither -d nor -f option isn't necessarily needed.)
>
I don't think so. The description is already there (see "pg_restore
can operate in two modes..."). I left -l as is which means that
'pg_restore -l foo.dump' dumps to standard output and 'pg_restore -f -
-l foo.dump' has the same behavior).

> I think the former one looks like pretty, but which one is preffered?
>
I don't have a style preference but decided to change to your
suggestion. New version attached.

--
Euler Taveira Timbira -
http://www.timbira.com.br/
PostgreSQL: Consultoria, Desenvolvimento, Suporte 24x7 e Treinamento

Attachment Content-Type Size
v3-0001-pg_restore-supports-stdout-in-file.patch text/x-patch 5.0 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Chris Cleveland 2019-03-16 23:24:11 Possible to modify query language in an extension?
Previous Message Ryan Lambert 2019-03-16 22:43:43 Re: Fix XML handling with DOCTYPE