Re: Fix typos

From: Sehrope Sarkuni <sehrope(at)jackdb(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Fix typos
Date: 2019-08-02 10:37:44
Message-ID: CAH7T-apB97-5isHj=Bi+JSpaE9_L+pH7gPr=Mi-ZgR7bdpr7rQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Aug 1, 2019 at 10:18 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:

> It's British vs. American spelling. For the most part, Postgres
> follows American spelling, but there's the odd Briticism here and
> there.

Thanks for the explanation. I thought that might be the case but didn't
find any other usages of "serialise" so was not sure.

> I'm not sure whether it's worth trying to standardize.
> I think the most recent opinion on this was Munro's:
>
>
> https://www.postgresql.org/message-id/CA+hUKGJz-pdMgWXroiwvN-aeG4-AjdWj3gWdQKOSa8g65spdVw@mail.gmail.com

Either reads fine to me and the best rationale I can think of for going
with one spelling is to not have the same "fix" come up again.

If there is a desire to change this, attached is updated to include one
more instance of "materialise" and a change to the commit message to match
some similar ones I found in the past.

Regards,
-- Sehrope Sarkuni
Founder & CEO | JackDB, Inc. | https://www.jackdb.com/

Attachment Content-Type Size
v2-0001-Use-American-spelling-for-serialize-and-materalize.patch application/x-patch 3.3 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Munro 2019-08-02 10:42:16 Re: Should we add xid_current() or a int8->xid cast?
Previous Message Thomas Munro 2019-08-02 10:36:18 Re: Store FullTransactionId in TwoPhaseFileHeader/GlobalTransactionData