Re: [PATCH] Fix for bug #19474: LIKE fails to match literal backslashes with nondeterministic collations

On Sat, Jul 4, 2026 at 3:03 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> I don't think this patch is ready. It is wasting code and cycles to
> fix a nonexistent problem. We are working in a backend-safe encoding,
> therefore it is not possible for one byte of a multibyte character to
> match '\' (nor '_' nor '%'). So the existing logic that pays no
> attention to multibyte boundaries is not wrong, and if it were then
> the preceding loop that looks for the end of the literal-match
> substring would also be wrong (as well as some hundreds of other
> places that make similar assumptions).
>
> This code does get consecutive-backslash cases wrong, and we need
> to fix that, but we don't need to add complexity to fix something
> that's not broken.
>

Thanks for the feedback, Tom. I have removed the logic for the
multibyte check and simplified the code. Please take a look at the
latest patch.

Regards,
Nitin Motiani
Google