| From: | Euler Taveira <euler(dot)taveira(at)2ndquadrant(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Craig Ringer <craig(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Devrim Gündüz <devrim(at)gunduz(dot)org> |
| Subject: | Re: [PATCH] Skip llvm bytecode generation if LLVM is missing |
| Date: | 2020-03-12 20:22:09 |
| Message-ID: | CAH503wC=abvOL4o_w=GwTH2uHbXtcrm=eh-ZWOSLAAnUUaB1VA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, 12 Mar 2020 at 16:25, Andres Freund <andres(at)anarazel(dot)de> wrote:
> Hi,
>
> On 2020-03-12 14:08:31 +0800, Craig Ringer wrote:
> >
> > I thought about that at first, but that'll only benefit people who're
> > hand-compiling things, and it's already possible with
> >
> > make with_llvm=no ...
>
> Well, the difference is that you'd be told about it, instead of getting
> a hard to parse error message.
>
> What about adding a WARNING but don't error out if LLVM isn't found? Add
an additional option (if LLVM isn't found) is annoying because it means
adding instruction into README of all extensions. What is the side effects
of not providing .bc files? It seems some extensions won't benefit from
LLVM.
Regards,
--
Euler Taveira http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2020-03-12 20:34:59 | Re: [PATCH] Skip llvm bytecode generation if LLVM is missing |
| Previous Message | David Rowley | 2020-03-12 20:10:59 | Re: Berserk Autovacuum (let's save next Mandrill) |