From: | Euler Taveira <euler(dot)taveira(at)2ndquadrant(dot)com> |
---|---|
To: | Julien Rouhaud <rjuju123(at)gmail(dot)com> |
Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Kuntal Ghosh <kuntalghosh(dot)2007(at)gmail(dot)com>, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, Kirill Bychik <kirill(dot)bychik(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
Subject: | Re: WAL usage calculation patch |
Date: | 2020-04-06 14:28:14 |
Message-ID: | CAH503wBqYx2+ZZMjr-B3WDD+UNruboVfGtKMNwaSaOcycHT+NQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Mon, 6 Apr 2020 at 10:37, Julien Rouhaud <rjuju123(at)gmail(dot)com> wrote:
> On Mon, Apr 06, 2020 at 10:12:55AM -0300, Euler Taveira wrote:
> > On Mon, 6 Apr 2020 at 00:25, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
> wrote:
> >
> > >
> > > I have pushed pg_stat_statements and Explain related patches. I am
> > > now looking into (auto)vacuum patch and have few comments.
> > >
> > > I wasn't paying much attention to this thread. May I suggest changing
> > wal_num_fpw to wal_fpw? wal_records and wal_bytes does not have a prefix
> > 'num'. It seems inconsistent to me.
> >
>
> If we want to be consistent shouldn't we rename it to wal_fpws? FTR I
> don't
> like much either version.
>
Since FPW is an acronym, plural form reads better when you are using
uppercase (such as FPWs or FPW's); thus, I prefer singular form because
parameter names are lowercase. Function description will clarify that this
is "number of WAL full page writes".
Regards,
--
Euler Taveira http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | freebsdjlu | 2020-04-06 14:32:15 | Re: Issues with replication slots(which created manually) against logical replication |
Previous Message | Tom Lane | 2020-04-06 14:09:12 | Re: d25ea01275 and partitionwise join |