Re: Added schema level support for publication.

Hi Vignesh,

> I have handled the above scenario(drop schema should automatically
> remove the schema entry from publication schema relation) & addition
> of tests in the new v2 patch attached.
> Thoughts?
>

Please see some initial comments:

1. I think there should be more tests to show that the schema data is
actually replicated
to the subscriber. Currently, I am not seeing the data being replicated
when I use FOR SCHEMA.

2. How does replication behave when a table is added or removed from a
subscribed schema
using ALTER TABLE SET SCHEMA?

3. Can we have a default schema like a public or current schema that gets
replicated in case the user didn't
specify one, this can be handy to replicate current schema tables.

4. + The fourth, fifth and sixth variants change which schemas are part
of the
+ publication. The <literal>SET TABLE</literal> clause will replace the
list
+ of schemas in the publication with the specified one. The <literal>ADD

There is a typo above s/SET TABLE/SET SCHEMA

Thank you,
Rahila Syed