Re: Extend injection_points_attach() to accept a user-defined function

From: Rahila Syed <rahilasyed90(at)gmail(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Extend injection_points_attach() to accept a user-defined function
Date: 2025-10-29 11:32:48
Message-ID: CAH2L28uHM_b3_g3zr0GiX2+efWjsX1J1f3EWgNaBwnFT9d_EYg@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

> How about a simpler injection_points_attach(point_name text, func
> text, module text) with a second SQL function, but a different number
> of arguments? Using a new hardcoded action for this purpose is
> confusing as your point is to introduce a SQL wrapper on top of
> InjectionPointAttach(), and using input arguments that match with the
> C function is an attractive option.

Thank you for the suggestion.
I agree that having a separate SQL function for this would make the design
easier to understand.

Please find attached a patch that implements this.

Thank you,
Rahila Syed

Attachment Content-Type Size
v2-0001-Overload-the-injection_points_attach-sql-function.patch application/octet-stream 2.8 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Álvaro Herrera 2025-10-29 11:36:55 Re: Bug in pg_stat_statements
Previous Message Aleksander Alekseev 2025-10-29 11:31:29 Re: Add uuid_to_base32hex() and base32hex_to_uuid() built-in functions