Re: [REVIEW] Re: Compression of full-page-writes

From: Rahila Syed <rahilasyed90(at)gmail(dot)com>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: Rahila Syed <rahilasyed(dot)90(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [REVIEW] Re: Compression of full-page-writes
Date: 2014-11-08 21:41:04
Message-ID: CAH2L28tVPQXi2ZD3RPW5R6hXbrj7ONzcfzZSwN4GPLs7Cdo6AQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hello,

>The patch was not applied to the master cleanly. Could you update the
patch?
Please find attached updated and rebased patch to compress FPW. Review
comments given above have been implemented.

Thank you,
Rahila Syed

On Thu, Nov 6, 2014 at 2:48 PM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:

> On Tue, Nov 4, 2014 at 2:03 PM, Rahila Syed <rahilasyed90(at)gmail(dot)com>
> wrote:
> > Hello ,
> >
> > Please find updated patch with the review comments given above
> implemented
>
> Hunk #3 FAILED at 692.
> 1 out of 3 hunks FAILED -- saving rejects to file
> src/backend/access/transam/xlogreader.c.rej
>
> The patch was not applied to the master cleanly. Could you update the
> patch?
>
> Regards,
>
> --
> Fujii Masao
>

Attachment Content-Type Size
compress_fpw_v4.patch application/octet-stream 32.3 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2014-11-08 21:46:25 Re: pg_multixact not getting truncated
Previous Message Andres Freund 2014-11-08 21:35:36 Re: Add CREATE support to event triggers