| From: | Rahila Syed <rahilasyed90(at)gmail(dot)com> |
|---|---|
| To: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
| Cc: | Florents Tselai <florents(dot)tselai(at)gmail(dot)com>, Sami Imseih <samimseih(at)gmail(dot)com>, Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: add function for creating/attaching hash table in DSM registry |
| Date: | 2025-06-30 07:59:22 |
| Message-ID: | CAH2L28sjQ5Vv6YrCYUtH9A1La55s53EKeHMWfMPN71ijKQhj-g@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
Here is what I have staged for commit.
>
>
Thank you for sharing the updated patch.
This looks good to me. I used the GetNamedDSA added by this patch in my
code and it worked fine.
/* XXX: Should we verify params matches what table was created with? */
Are you planning to address the above before you commit? It seems like a
helpful check since GetNamedDshash
takes the params as arguments. That said, I don't have a strong preference
either way.
I have a question: is there a way to remove the entries from the registry
and free the space?
For example, if a user decides to call dshash_destroy the dshash entry in
the registry would no longer be needed.
Thank you,
Rahila Syed
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Krasiyan Andreev | 2025-06-30 08:08:26 | Re: Add RESPECT/IGNORE NULLS and FROM FIRST/LAST options |
| Previous Message | torikoshia | 2025-06-30 07:57:30 | Re: speedup COPY TO for partitioned table. |