From: | Peter Geoghegan <pg(at)bowt(dot)ie> |
---|---|
To: | David Rowley <dgrowleyml(at)gmail(dot)com> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Making C function declaration parameter names consistent with corresponding definition names |
Date: | 2022-09-19 03:04:12 |
Message-ID: | CAH2-WznsP1R9UrXsp5LMoRTKt5-BApZAkZ80E-qvvVSicgEoAg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Sun, Sep 18, 2022 at 5:08 PM Peter Geoghegan <pg(at)bowt(dot)ie> wrote:
> That was left behind following a recent rebase. Will fix.
Attached revision fixes this issue, plus the
ExecIncrementalSortInitializeWorker() issue.
It also adds a lot more fixes which were missed earlier because I
didn't use "strict" when running clang-tidy from the command line
(just in my editor). This includes a fix for the mdexists() issue that
you highlighted.
I expect that this patch series will bitrot frequently, so there is no
good reason to not post revisions frequently.
The general structure of the patchset is now a little more worked out.
Although it's still not close to being commitable, it should give you
a better idea of the kind of structure that I'm aiming for. I think
that this should be broken into a few different parts based on the
area of the codebase affected (not the type of check used). Even that
aspect needs more work, because there is still one massive patch --
this is now the sixth and final patch.
It seems like a good idea to at least have separate commits for both
the regex code and the timezone code, since these are "quasi-vendored"
areas of the code base.
--
Peter Geoghegan
Attachment | Content-Type | Size |
---|---|---|
v3-0001-Harmonize-parameter-names-in-regex-code.patch | application/octet-stream | 27.0 KB |
v3-0004-Harmonize-parameter-names-in-pg_dump-pg_dumpall.patch | application/octet-stream | 48.3 KB |
v3-0005-Harmonize-parameter-names-in-jsonb-code.patch | application/octet-stream | 11.4 KB |
v3-0006-Harmonize-parameter-names-in-miscellaneous-code.patch | application/octet-stream | 210.8 KB |
v3-0003-Harmonize-parameter-names-in-heapam-and-related-c.patch | application/octet-stream | 25.3 KB |
v3-0002-Harmonize-parameter-names-in-timezone-code.patch | application/octet-stream | 5.9 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Zhang Mingli | 2022-09-19 03:05:24 | Re: Fix typos in code comments |
Previous Message | Amit Kapila | 2022-09-19 02:57:16 | Re: Fix typos in code comments |