| From: | Peter Geoghegan <pg(at)bowt(dot)ie> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Jeff Davis <pgsql(at)j-davis(dot)com>, David Rowley <dgrowleyml(at)gmail(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andres Freund <andres(at)anarazel(dot)de>, Bruce Momjian <bruce(at)momjian(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Melanie Plageman <melanieplageman(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Default setting for enable_hashagg_disk |
| Date: | 2020-07-27 18:30:39 |
| Message-ID: | CAH2-Wznmr5r2GtRh4h7AYP+d6EGyKFmKg39wp71ei2UC5db3zA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-docs pgsql-hackers |
On Mon, Jul 27, 2020 at 11:24 AM Alvaro Herrera
<alvherre(at)2ndquadrant(dot)com> wrote:
> > Are you proposing that I just put the prototype in miscadmin.h, while
> > leaving the implementation where it is (in nodeHash.c)?
>
> Yes, that's in the part of my reply you didn't quote:
>
> : It remains strange to have the function in executor
> : implementation, but I don't offhand see a better place, so maybe it's
> : okay where it is.
Got it.
I tried putting the prototype in miscadmin.h, and I now agree that
that's the best way to do it -- that's how I do it in the attached
revision. No other changes.
The v4-0001-Remove-hashagg_avoid_disk_plan-GUC.patch changes are
surprisingly complicated. It would be nice if you could take a look at
that aspect (or confirm that it's included in your review).
--
Peter Geoghegan
| Attachment | Content-Type | Size |
|---|---|---|
| v4-0001-Remove-hashagg_avoid_disk_plan-GUC.patch | application/octet-stream | 10.1 KB |
| v4-0002-Add-hash_mem_multiplier-GUC.patch | application/octet-stream | 35.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2020-07-27 19:52:32 | Re: Default setting for enable_hashagg_disk |
| Previous Message | Alvaro Herrera | 2020-07-27 18:24:36 | Re: Default setting for enable_hashagg_disk |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nasby, Jim | 2020-07-27 18:39:36 | FW: autovac issue with large number of tables |
| Previous Message | Alvaro Herrera | 2020-07-27 18:24:36 | Re: Default setting for enable_hashagg_disk |