Re: Adding an LWLockHeldByMe()-like function that reports if any buffer content lock is held

From: Peter Geoghegan <pg(at)bowt(dot)ie>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Adding an LWLockHeldByMe()-like function that reports if any buffer content lock is held
Date: 2018-04-19 02:58:15
Message-ID: CAH2-WznbrnEHXPAK0xx8vhPtdUE7yXqtNYdbbR4=Dn_pgzv94g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Apr 18, 2018 at 6:53 PM, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>> I'm curious about what we'll find by just by adding
>> Assert(!AnyBufferLockHeldByMe()) to the top of
>> heap_tuple_fetch_attr(). AssertNotInCriticalSection() certainly found
>> several bugs when it was first added.
>
> Yep.

I wrote a simple prototype of this. No assertion failed during a "make
installcheck". Assertions were added to heap_tuple_fetch_attr(), and a
couple of other places.

--
Peter Geoghegan

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Kyotaro HORIGUCHI 2018-04-19 03:01:45 Re: Postgres 10 problem with UNION ALL of null value in "subselect"
Previous Message Masahiko Sawada 2018-04-19 02:35:02 Re: VM map freeze corruption