| From: | Peter Geoghegan <pg(at)bowt(dot)ie> |
|---|---|
| To: | Chapman Flack <chap(at)anastigmatix(dot)net> |
| Cc: | Melanie Plageman <melanieplageman(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Sort support for macaddr8 |
| Date: | 2019-06-03 21:48:50 |
| Message-ID: | CAH2-WznUEpFkfDSye-RVXrW_K+hNSpYntSk8spF1ZxENWqnR3g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Jun 3, 2019 at 2:03 PM Chapman Flack <chap(at)anastigmatix(dot)net> wrote:
> Am I going cross-eyed, or would the memset be serving more of a purpose
> if it were in the SIZEOF_DATUM != 8 branch?
No, it wouldn't -- that's the correct place for it with the macaddr
type. However, it isn't actually necessary to memset() at the
equivalent point for macaddr8, since we cannot "run out of bytes from
the authoritative representation" that go in the Datum/abbreviated
key. I suppose that the memset() should simply be removed, since it is
superfluous here.
--
Peter Geoghegan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jared Rulison | 2019-06-03 21:54:41 | Use of multi-column gin index |
| Previous Message | Philip Dubé | 2019-06-03 21:42:50 | [PATCH] ruleutils: Fix subqueries with shadowed aliases |