| From: | Peter Geoghegan <pg(at)bowt(dot)ie> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Subject: | Re: Fixing a couple of buglets in how VACUUM sets visibility map bits |
| Date: | 2023-01-09 18:16:03 |
| Message-ID: | CAH2-WznRTzmNRVpV6pxsc_=zieizDGObYYR2ek6MJ5dqOZFc7A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, Jan 8, 2023 at 6:43 PM Peter Geoghegan <pg(at)bowt(dot)ie> wrote:
> On further reflection even v2 won't repair the page-level
> PD_ALL_VISIBLE flag in passing in this scenario. ISTM that on HEAD we
> might actually leave the all-frozen bit set in the VM, while both the
> all-visible bit and the page-level PD_ALL_VISIBLE bit remain unset.
> Again, all due to the approach we take with
> all_visible_according_to_vm, which can go stale independently of both
> the VM bit being unset and the PD_ALL_VISIBLE bit being unset (in my
> example problem scenario).
Attached is v3, which explicitly checks the need to set the
PD_ALL_VISIBLE flag at the relevant visibilitymap_set() call site. It
also has improved comments.
--
Peter Geoghegan
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-Don-t-accidentally-unset-all-visible-bit-in-VM.patch | application/octet-stream | 13.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Önder Kalacı | 2023-01-09 18:21:36 | Re: [PATCH] Use indexes on the subscriber when REPLICA IDENTITY is full on the publisher |
| Previous Message | Nathan Bossart | 2023-01-09 17:53:57 | Re: Common function for percent placeholder replacement |