Re: The unused_oids script should have a reminder to use the 8000-8999 OID range

From: Peter Geoghegan <pg(at)bowt(dot)ie>
To: Julien Rouhaud <rjuju123(at)gmail(dot)com>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: The unused_oids script should have a reminder to use the 8000-8999 OID range
Date: 2019-08-02 18:12:34
Message-ID: CAH2-WznHrXoEN8qp57gTLQEtDao-xCr_ZXP7-Sqyr315rW4ZvQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Aug 2, 2019 at 1:42 AM Julien Rouhaud <rjuju123(at)gmail(dot)com> wrote:
> Trivial patch for that attached.

Thanks!

> The output is now like:
>
> [...]
> Using an oid in the 8000-9999 range is recommended.
> For instance: 9427
>
> (checking that the suggested random oid is not used yet.)

I've taken your patch, and changed the wording a bit. I think that
it's worth being a bit more explicit. The attached revision produces
output that looks like this:

Patches should use a more-or-less consecutive range of OIDs.
Best practice is to make a random choice in the range 8000-9999.
Suggested random unused OID: 9099

I would like to push this patch shortly. How do people feel about this
wording? (It's based on the documentation added by commit a6417078.)

--
Peter Geoghegan

Attachment Content-Type Size
v2-0001-unused_oids-suggestion.patch application/octet-stream 888 bytes

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2019-08-02 18:20:03 Re: pglz performance
Previous Message Andres Freund 2019-08-02 18:01:38 Re: partition routing layering in nodeModifyTable.c