Re: s/pg_attribute_always_inline/pg_always_inline/?

From: Peter Geoghegan <pg(at)bowt(dot)ie>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Peter Eisentraut <peter(at)eisentraut(dot)org>, pgsql-hackers(at)postgresql(dot)org, Tomas Vondra <tomas(at)vondra(dot)me>
Subject: Re: s/pg_attribute_always_inline/pg_always_inline/?
Date: 2026-05-27 22:17:20
Message-ID: CAH2-WznHSUJcV47OhoisvABjN2xjVOYh0_bRagUE6ir5zGJzow@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Apr 9, 2026 at 10:40 AM Andres Freund <andres(at)anarazel(dot)de> wrote:
> Created a CF entry, to reduce the chances of me forgetting about committing
> this early in the 20 cycle.

We already have a pg_noinline. How about renaming
pg_attribute_always_inline to pg_mustinline? That is an alternative
that is both consistent with pg_noinline, and even terser than your
proposal.

I have no intention of holding this patch up with bikeshedding. But I
noticed that even your proposed pg_always_inline rename still leaves
function prototypes over the column limit with moderately verbose
function names. It seems better to avoid that outcome.

--
Peter Geoghegan

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Srinivas Kumar 2026-05-27 22:18:34 Re: DBeaver Experiencing timeouts while connecting to New Linux PostgreSql server
Previous Message Jacob Champion 2026-05-27 22:15:46 Re: Heads Up: cirrus-ci is shutting down June 1st