| From: | Peter Geoghegan <pg(at)bowt(dot)ie> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: pgsql: Delay commit status checks until freezing executes. |
| Date: | 2023-01-06 19:16:00 |
| Message-ID: | CAH2-Wzn4bEEqgmaUQL3aJ73yM9gAeK-wE4ngi7kjRjLztb+P0w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Tue, Jan 3, 2023 at 10:52 PM Peter Geoghegan <pg(at)bowt(dot)ie> wrote:
> > And it'd make sense to have
> > the explanation of why TransactionIdDidAbort() isn't the same as
> > !TransactionIdDidCommit(), even for !TransactionIdIsInProgress() xacts, near
> > the explanation for doing TransactionIdIsInProgress() first.
>
> I think that we should definitely have a comment directly over
> TransactionIdDidAbort(). Though I wouldn't mind reorganizing these
> other comments, or making the comment over TransactionIdDidAbort()
> mostly just point to the other comments.
What do you think of the attached patch, which revises comments over
TransactionIdDidAbort, and adds something about it to the top of
heapam_visbility.c?
--
Peter Geoghegan
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0001-Document-TransactionIdDidAbort-hard-crash-behavio.patch | application/octet-stream | 3.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2023-01-06 19:17:32 | pgsql: Add options to control whether VACUUM runs vac_update_datfrozenx |
| Previous Message | Tom Lane | 2023-01-06 16:12:13 | pgsql: Invalidate pgoutput's replication-decisions cache upon schema re |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jacob Champion | 2023-01-06 19:56:09 | Re: Introduce "log_connection_stages" setting. |
| Previous Message | Jim Jones | 2023-01-06 19:04:10 | Re: Authentication fails for md5 connections if ~/.postgresql/postgresql.{crt and key} exist |