| From: | Peter Geoghegan <pg(at)bowt(dot)ie> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Bruce Momjian <bruce(at)momjian(dot)us>, Ranier Vilela <ranier_gyn(at)hotmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Remove twice assignment with var pageop (nbtree.c). |
| Date: | 2019-12-19 18:05:18 |
| Message-ID: | CAH2-Wzn=TaNfJahPEjNrqrVax6raq8s6Od53SHh9LhSRWaP9Fw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Dec 19, 2019 at 7:55 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> I don't think this is actually a good idea. What it is is a foot-gun,
> because if anyone adds code there that wants to access the special area
> of that particular page, it'll do the wrong thing, unless they remember
> to put back the assignment of "opaque". The sequence of BufferGetPage()
> and PageGetSpecialPointer() is a very standard switch-our-attention-
> to-another-page locution in nbtree and other index AMs.
+1
--
Peter Geoghegan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dave Cramer | 2019-12-19 18:15:20 | Re: How is this possible "publication does not exist" |
| Previous Message | Robert Haas | 2019-12-19 17:52:39 | Re: [PATCH] Increase the maximum value track_activity_query_size |