| From: | Peter Geoghegan <pg(at)bowt(dot)ie> |
|---|---|
| To: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
| Cc: | Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Claudio Freire <klaussfreire(at)gmail(dot)com>, Anastasia Lubennikova <a(dot)lubennikova(at)postgrespro(dot)ru>, "Andrey V(dot) Lepikhov" <a(dot)lepikhov(at)postgrespro(dot)ru> |
| Subject: | Re: Making all nbtree entries unique by having heap TIDs participate in comparisons |
| Date: | 2019-03-19 23:15:39 |
| Message-ID: | CAH2-WzmrJMs7BX+eNGmK0hXEK6fVxYDZ5y-ZOq-3vhCBNT-J+w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Mar 18, 2019 at 10:17 AM Peter Geoghegan <pg(at)bowt(dot)ie> wrote:
> The big difference is that you make the possible call to
> _bt_stepright() conditional on this being a checkingunique index --
> the duplicate code is indented in that branch of _bt_findsplitloc().
> Whereas I break early in the loop when "checkingunique &&
> heapkeyspace".
Heikki and I discussed this issue privately, over IM, and reached
final agreement on remaining loose ends. I'm going to use his code for
_bt_findsplitloc(). Plan to push a final version of the first four
patches tomorrow morning PST.
--
Peter Geoghegan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Paul Ramsey | 2019-03-19 23:36:27 | Re: Compressed TOAST Slicing |
| Previous Message | Michael Paquier | 2019-03-19 23:09:07 | Re: Offline enabling/disabling of data checksums |