Re: Can can I make an injection point wait occur no more than once?

From: Peter Geoghegan <pg(at)bowt(dot)ie>
To: Noah Misch <noah(at)leadboat(dot)com>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Can can I make an injection point wait occur no more than once?
Date: 2025-07-07 22:31:33
Message-ID: CAH2-WzmccKur-zmoPS3X66vCHTFD_knuSZPhpKSgd9=5aRzSqw@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Jul 7, 2025 at 6:02 PM Noah Misch <noah(at)leadboat(dot)com> wrote:
> In your test, just detach the injection point while the backend under test is
> waiting at the injection point. All of
> src/test/modules/injection_points/specs/*.spec use that technique.

That appears to work (without the kludge I added to nbtsearch.c),
though I find that I need to detach the injection point *and* wake up
the waiting backend. In that order. Thanks!

For what it's worth, I found
src/test/modules/injection_points/specs/basic.spec (which is supposed
to serve as a template) hard to follow. The comments don't seem to
explain what the detach and wait functions actually do, and how and
why one might want to call them together.

--
Peter Geoghegan

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tomas Vondra 2025-07-07 22:35:43 Re: Adding basic NUMA awareness - Preliminary feedback and outline for an extensible approach
Previous Message Noah Misch 2025-07-07 22:02:17 Re: Can can I make an injection point wait occur no more than once?