| From: | Peter Geoghegan <pg(at)bowt(dot)ie> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: BTMaxItemSize seems to be subtly incorrect |
| Date: | 2022-08-05 20:10:47 |
| Message-ID: | CAH2-Wzm_dbQLOmpxymmTg-CK7wgxPjd7c2hxrZafjtwLHXq8WQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Aug 5, 2022 at 10:13 AM Peter Geoghegan <pg(at)bowt(dot)ie> wrote:
> Update: I discovered that I can get the regression tests to fail (even
> on mainstream 64-bit platforms) by MAXALIGN()'ing the expression that
> we assign to state->maxpostingsize at the top of _bt_dedup_pass().
Looks like this was nothing more than a silly oversight with how the
macro was defined. As written, it would evaluate to the wrong thing at
the same point in nbtdedup.c, just because it was used in an
expression.
Pushed a fix for that just now.
--
Peter Geoghegan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2022-08-05 20:25:10 | Re: optimize lookups in snapshot [sub]xip arrays |
| Previous Message | David Zhang | 2022-08-05 19:46:27 | Re: Hash index build performance tweak from sorting |