Re: GlobalVisIsRemovableFullXid() vs GlobalVisCheckRemovableXid()

From: Peter Geoghegan <pg(at)bowt(dot)ie>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
Subject: Re: GlobalVisIsRemovableFullXid() vs GlobalVisCheckRemovableXid()
Date: 2021-02-14 21:01:57
Message-ID: CAH2-WzmVR4SakBXQUdhhPpMf1aYvZCnna5=HKa7DAgEmBAg+8g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Feb 6, 2021 at 7:40 PM Andres Freund <andres(at)anarazel(dot)de> wrote:
> Looks like a mistake on my part... Probably a rename regex that somehow
> went wrong - I went back and forth on those names way too many
> times. Want me to push the fix?

Spotted another one: Shouldn't ReadNextFullTransactionId() actually be
called ReadNewFullTransactionId()? Actually, the inverse approach
looks like it produces fewer inconsistencies: you could instead rename
ReadNewTransactionId() to ReadNextTransactionId().

--
Peter Geoghegan

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Justin Pryzby 2021-02-14 21:03:38 Re: [POC] Fast COPY FROM command for the table with foreign partitions
Previous Message Justin Pryzby 2021-02-14 20:28:31 Re: [HACKERS] Custom compression methods