| From: | Peter Geoghegan <pg(at)bowt(dot)ie> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Julien Rouhaud <rjuju123(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: The unused_oids script should have a reminder to use the 8000-8999 OID range |
| Date: | 2019-08-02 21:50:42 |
| Message-ID: | CAH2-WzmS5bG36zSyXSAq+p8GUD4_BMT=iz4PuxogrdOh1j=Z5A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Aug 2, 2019 at 1:49 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Maybe s/make a/start with/ ?
> Also, once people start doing this, it'd be unfriendly to suggest
> 9099 if 9100 is already committed. There should be some attention
> to *how many* consecutive free OIDs will be available if one starts
> at the suggestion.
How about this wording?:
Patches should use a more-or-less consecutive range of OIDs.
Best practice is to start with a random choice in the range 8000-9999.
Suggested random unused OID: 9591 (409 consecutive OID(s) available
starting here)
Attached is v3, which implements your suggestion, generating output
like the above. I haven't written a line of Perl in my life prior to
today, so basic code review would be helpful.
--
Peter Geoghegan
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-unused_oids-suggestion.patch | application/octet-stream | 1.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Isaac Morland | 2019-08-02 21:52:31 | Re: The unused_oids script should have a reminder to use the 8000-8999 OID range |
| Previous Message | Andres Freund | 2019-08-02 21:01:52 | Re: partition routing layering in nodeModifyTable.c |