| From: | Peter Geoghegan <pg(at)bowt(dot)ie> |
|---|---|
| To: | Rushabh Lathia <rushabh(dot)lathia(at)gmail(dot)com> |
| Cc: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Corey Huinker <corey(dot)huinker(at)gmail(dot)com> |
| Subject: | Re: [HACKERS] Parallel tuplesort (for parallel B-Tree index creation) |
| Date: | 2017-11-15 18:39:58 |
| Message-ID: | CAH2-Wzm2mizm6gYOGFSdc1J5OmLdMWDRN1up0sLpU79a_SGFfg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Nov 14, 2017 at 10:01 AM, Peter Geoghegan <pg(at)bowt(dot)ie> wrote:
> On Tue, Nov 14, 2017 at 1:41 AM, Rushabh Lathia
> <rushabh(dot)lathia(at)gmail(dot)com> wrote:
>> Thanks Peter and Thomas for the review comments.
>
> No problem. More feedback:
I see that Robert just committed support for a
parallel_leader_participation GUC. Parallel tuplesort should use this,
too.
It will be easy to adopt the patch to make this work. Just change the
code within nbtsort.c to respect parallel_leader_participation, rather
than leaving that as a compile-time switch. Remove the
force_single_worker variable, and use !parallel_leader_participation
in its place.
The parallel_leader_participation docs will also need to be updated.
--
Peter Geoghegan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2017-11-15 18:48:18 | Re: [HACKERS] [POC] Faster processing at Gather node |
| Previous Message | Andres Freund | 2017-11-15 18:35:49 | Re: [HACKERS] Parallel Hash take II |