| From: | Peter Geoghegan <pg(at)bowt(dot)ie> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Michael Paquier <michael(at)paquier(dot)xyz>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Pavan Deolasee <pavan(dot)deolasee(at)gmail(dot)com>, Anastasia Lubennikova <a(dot)lubennikova(at)postgrespro(dot)ru>, Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, Paul Guo <guopa(at)vmware(dot)com> |
| Subject: | Re: Performance degradation of REFRESH MATERIALIZED VIEW |
| Date: | 2021-05-13 02:47:31 |
| Message-ID: | CAH2-Wzm0b6a6a4x1ObE2SH_S-UEdmd32_sfBmxcjoJ4QHjEcUQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, May 11, 2021 at 11:46 AM Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
> > Yes, reverting has its place. Moreover, threats of reversion have their
> > place. People should definitely be working towards finding solutions to
> > the problems in their commits lest they be reverted. However, freezing
> > *people* by saying that no fixes are acceptable other than reverts ...
> > is not good.
> >
> > So I agree with what Andres is saying downthread: let's apply the fix he
> > proposed (it's not even that invasive anyway), and investigate the
> > remaining 5% and see if we can find a solution. If by the end of the
> > beta process we can definitely find no solution to the problem, we can
> > revert the whole lot then.
> >
>
>
> I agree with all of this. Right now I'm only concerned if there isn't
> work apparently being done on some issue.
+1. While reverting a patch is always on the table, it must be the
option of last resort. I don't have any specific reason to believe
that that's the point we're at just yet.
--
Peter Geoghegan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kyotaro Horiguchi | 2021-05-13 02:49:34 | Re: compute_query_id and pg_stat_statements |
| Previous Message | Julien Rouhaud | 2021-05-13 02:43:03 | Re: compute_query_id and pg_stat_statements |