| From: | Peter Geoghegan <pg(at)bowt(dot)ie> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Robert Haas <robertmhaas(at)gmail(dot)com>, Maxim Orlov <orlovmg(at)gmail(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: old_snapshot_threshold bottleneck on replica |
| Date: | 2023-09-08 04:22:23 |
| Message-ID: | CAH2-WzktQMRbJRKxvs+haY8fTH+zW+PyyoKewuHzQr=uY+AR=A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Sep 7, 2023 at 8:49 PM Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
> The code moved around quite a few times over several commits and quite
> a lot since then, which is why I didn't go for straight revert, but
> clearly the manual approach risked missing things.
It's not a big deal, obviously.
> I think the
> attached removes all unused 'snapshot' arguments from AM-internal
> functions. Checked by compiling with clang's -Wunused-parameters, and
> then searching for 'snapshot', and excluding the expected cases.
This looks right to me.
Thanks
--
Peter Geoghegan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jingtang Zhang | 2023-09-08 04:23:17 | Suspicious redundant assignment in COPY FROM |
| Previous Message | Nathan Bossart | 2023-09-08 04:21:07 | Re: Document that server will start even if it's unable to open some TCP/IP ports |