Re: ERROR: failed to add item to the index page

From: Peter Geoghegan <pg(at)bowt(dot)ie>
To: Andreas Joseph Krogh <andreas(at)visena(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: ERROR: failed to add item to the index page
Date: 2019-04-30 17:58:31
Message-ID: CAH2-Wzkd3i9hZikY7+MH7t3TWKOON+W8_0ZspUn+uwOoQFJeGA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Apr 30, 2019 at 9:59 AM Peter Geoghegan <pg(at)bowt(dot)ie> wrote:
> I'll start investigating the problem right away.

I have found what the problem is. I simply neglected to make a
conservative assumption about suffix truncation needing to add a heap
TID to a leaf page's new high key in nbtsort.c (following commit
dd299df8189), even though I didn't make the same mistake in
nbtsplitloc.c. Not sure how I managed to make such a basic error.

Andreas' test case works fine with the attached patch. I won't push a
fix for this today.

--
Peter Geoghegan

Attachment Content-Type Size
0001-Tentative-fix-for-nbtsort.c-space-bug.patch application/octet-stream 992 bytes

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Steve Crawford 2019-04-30 17:59:26 Re: CHAR vs NVARCHAR vs TEXT performance
Previous Message Andres Freund 2019-04-30 17:49:50 Re: performance regression when filling in a table