Re: Reducing the WAL overhead of freezing in VACUUM by deduplicating per-tuple freeze plans

From: Peter Geoghegan <pg(at)bowt(dot)ie>
To: Justin Pryzby <pryzby(at)telsasoft(dot)com>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Reducing the WAL overhead of freezing in VACUUM by deduplicating per-tuple freeze plans
Date: 2022-11-11 18:38:57
Message-ID: CAH2-WzkTrivGxWXLM0fBa9RTTdTmxUhPE+sXoAMgeagmNKLjtA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Nov 10, 2022 at 7:00 PM Justin Pryzby <pryzby(at)telsasoft(dot)com> wrote:
> Note that this comment is dangling in your patch:

Attached is v4, which removes the old comments you pointed out were
now out of place (they weren't adding much anyway). Also fixed bitrot
against HEAD from today's visibility map commit from Jeff Davis.

There is a more substantive change here, too. Like v3, v4 refactors
the *mechanical* details of how the XID based cutoff is handed down.
However, unlike v3, v4 goes back to using vacuumlazy.c's FreezeLimit
as the starting point for generating a latestRemovedXid. It seemed
better to deal with the recovery conflict issues created by my big
page-level freezing/freezing strategy patch set in the patch set
itself.

Will commit this early next week barring any objections.

Thanks
--
Peter Geoghegan

Attachment Content-Type Size
v4-0001-Shrink-freeze-WAL-records-via-deduplication.patch application/octet-stream 24.3 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Imseih (AWS), Sami 2022-11-11 19:10:16 Re: Add index scan progress to pg_stat_progress_vacuum
Previous Message Alvaro Herrera 2022-11-11 17:35:06 Re: Add LSN along with offset to error messages reported for WAL file read/write/validate header failures