| From: | Peter Geoghegan <pg(at)bowt(dot)ie> |
|---|---|
| To: | Teodor Sigaev <teodor(at)sigaev(dot)ru> |
| Cc: | Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>, Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, Anastasia Lubennikova <a(dot)lubennikova(at)postgrespro(dot)ru>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: WIP: Covering + unique indexes. |
| Date: | 2018-04-18 20:45:00 |
| Message-ID: | CAH2-WzkRh4z+ABtSUU1DUOgOOSEm_7zKg=p_AQXii+m84rJgPw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Apr 18, 2018 at 1:32 PM, Teodor Sigaev <teodor(at)sigaev(dot)ru> wrote:
>> I don't understand. We do check the number of attributes on rightmost
>> pages, but we do so separately, in the main loop. For every item that
>> isn't the high key.
>
> Comment added, pls, verify. And refactored _bt_check_natts(), I hope, now
> it's a bit more readable.
The new comment looks good.
Now I understand what you meant about _bt_check_natts(). And, I agree
that this is an improvement -- the extra verbosity is worth it.
> I didn't do that in v1, sorry, I was unclear. Attached patch contains all
> changes suggested in my previous email.
Looks new BTreeTupSetNAtts () assertion good to me.
I suggest committing this patch as-is.
Thank you
--
Peter Geoghegan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2018-04-18 20:49:17 | Re: Truncation failure in autovacuum results in data corruption (duplicate keys) |
| Previous Message | Teodor Sigaev | 2018-04-18 20:32:07 | Re: WIP: Covering + unique indexes. |