From: | Peter Geoghegan <pg(at)bowt(dot)ie> |
---|---|
To: | Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com> |
Cc: | Alexander Lakhin <exclusion(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com> |
Subject: | Re: BUG #17212: pg_amcheck fails on checking temporary relations |
Date: | 2021-10-05 03:28:46 |
Message-ID: | CAH2-WzkPc3O91uYSAnrDMyEZGpcJh5ccqH-QgnfL1Kts13Ga7g@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-bugs pgsql-hackers |
On Mon, Oct 4, 2021 at 8:19 PM Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com> wrote:
> I am changing pg_amcheck to filter out indexes as you say. Since the btree check should no longer error in these cases, the issue of pg_amcheck exit(2) sorts itself out without further code changes.
Cool.
> I am changing verify_heapam to skip unlogged tables during recovery. In testing, checking such a table results in a simple notice:
>
> NOTICE: cannot verify unlogged relation "u_tbl" during recovery, skipping
That makes sense to me.
> While testing, I also created an index on the unlogged table and checked that index using bt_index_parent_check, and was surprised that checking it using bt_index_parent_check raises an error:
>
> ERROR: cannot acquire lock mode ShareLock on database objects while recovery is in progress
> HINT: Only RowExclusiveLock or less can be acquired on database objects during recovery.
Calling bt_index_parent_check() in hot standby mode is kind of asking
for it to error-out. It requires a ShareLock on the relation, which is
inherently not possible during recovery. So I don't feel too badly
about letting it just happen.
> So I am changing pg_amcheck to filter out indexes when pg_is_in_recovery() is true and relpersistence='u'. Does that sound right to you?
Yes, that all sounds right to me.
Thanks
--
Peter Geoghegan
From | Date | Subject | |
---|---|---|---|
Next Message | PG Bug reporting form | 2021-10-05 05:41:49 | BUG #17214: HammerDB-v4.2-TPCH build schema error for virtual users. |
Previous Message | Mark Dilger | 2021-10-05 03:19:02 | Re: BUG #17212: pg_amcheck fails on checking temporary relations |
From | Date | Subject | |
---|---|---|---|
Next Message | Bossart, Nathan | 2021-10-05 03:31:52 | Re: parallelizing the archiver |
Previous Message | Bossart, Nathan | 2021-10-05 03:26:09 | Re: Delegating superuser tasks to new security roles (Was: Granting control of SUSET gucs to non-superusers) |