| From: | Peter Geoghegan <pg(at)bowt(dot)ie> |
|---|---|
| To: | Mircea Cadariu <cadariu(dot)mircea(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Saving stack space in nbtree's _bt_first function |
| Date: | 2025-07-16 17:08:21 |
| Message-ID: | CAH2-WzkH=07vK8zEeJEf0xbyV77QgTJ9A6AHD52sPbnHH1cs8Q@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jul 16, 2025 at 9:17 AM Mircea Cadariu <cadariu(dot)mircea(at)gmail(dot)com> wrote:
> Thanks for the elaboration and updated patch! Indeed, I see it's set in
> the ScanKeyEntryInitialize to either BTGreaterStrategyNumber or
> BTLessStrategyNumber, then few lines lower there's the if with the break.
>
> I'm convinced.
Pushed.
> I noticed this CI job failure for the V2, seems unrelated to the subject
> of the patch though, does it need a retry?
> https://cirrus-ci.com/task/5781246762024960
It must be unrelated. I didn't see any such failure myself just now,
and I can't imagine how it could possibly be relevant.
Thanks for the review
--
Peter Geoghegan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2025-07-16 17:26:04 | Re: small fix for pg_overexplain docs |
| Previous Message | Jeff Davis | 2025-07-16 17:03:44 | Re: pg_dumpall dumps global objects with --statistics-only or --no-schema |