Re: Varying results when using merge joins over postgres_fdw vs hash joins

From: Peter Geoghegan <pg(at)bowt(dot)ie>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>, Corey Huinker <corey(dot)huinker(at)gmail(dot)com>, PostgreSQL <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Varying results when using merge joins over postgres_fdw vs hash joins
Date: 2017-09-20 16:20:31
Message-ID: CAH2-Wzk5Wj96Rf53jrV367w=i7x3dpzuUmnic=vbns998jHTeQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Sep 20, 2017 at 9:06 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> It is that. I'm tempted to propose that we invent some kind of "unknown"
> collation, which the planner would have to be taught to not equate to any
> other column collation (not even other instances of "unknown"), and that
> postgres_fdw's IMPORT ought to label remote columns with that collation
> unless specifically told to do otherwise. Then it's on the user's head
> if he tells us to do the wrong thing; but we won't produce incorrect
> plans by default.
>
> This is, of course, not at all a back-patchable fix.

I would like postgres_fdw to be taught about collation versioning, so
that postgres_fdw's IMPORT could automatically do the right thing when
ICU is in use. Maybe it's too early to discuss that, because we don't
even support alternative collation provider collations as the
database/cluster default collation just yet. FWIW, postgres_fdw +
collations was one of the issues that made me believe in the long term
strategic importance of ICU.

Anyway, I'm pretty sure that we also need to do something about this
in the short term. Maybe a prominent warning about server collation in
the postgres_fdw docs, or a user-visible NOTICE when incompatible
server collations are observed by postgres_fdw's IMPORT?

--
Peter Geoghegan

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2017-09-20 16:28:02 Re: Varying results when using merge joins over postgres_fdw vs hash joins
Previous Message Corey Huinker 2017-09-20 16:18:46 Re: Varying results when using merge joins over postgres_fdw vs hash joins