Re: pageinspect get_raw_page() option to return invalid pages

From: Peter Geoghegan <pg(at)bowt(dot)ie>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pageinspect get_raw_page() option to return invalid pages
Date: 2018-05-04 18:42:35
Message-ID: CAH2-Wzk-He76J1y6NbQ6vv_tWKYwf7iyitXGbBJeYoaZeKPe-Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, May 4, 2018 at 11:41 AM, Andres Freund <andres(at)anarazel(dot)de> wrote:
> Hi,
>
> Currently there's no convenient way to get a corrupted page (be it a
> checksum failure, corrupted pd_upper/lower or whatnot) via pageinspect's
> get_raw_page(). Given that pageinspect is kind of our tool to do inspect
> issues on a data level that's not so great.
>
> I therefore propose that we add an *option* that bypasses shared buffers
> and reads the underlying data directly. And then skips over the
> validation. I'm not 100% sure if this should be done unconditionally,
> or only if the item wasn't found in cache. There's some coherency
> differences, obviously.

+1. This would be a good option for amcheck, too.

--
Peter Geoghegan

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2018-05-04 18:46:56 Re: pageinspect get_raw_page() option to return invalid pages
Previous Message Andres Freund 2018-05-04 18:41:20 pageinspect get_raw_page() option to return invalid pages