Re: s/pg_attribute_always_inline/pg_always_inline/?

From: Peter Geoghegan <pg(at)bowt(dot)ie>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: s/pg_attribute_always_inline/pg_always_inline/?
Date: 2026-04-08 21:30:21
Message-ID: CAH2-Wzk-=_jppioxmiFSo=a5NGNoVkV2AYt_xKU+qPOQiQtLzg@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Apr 8, 2026 at 5:09 PM Andres Freund <andres(at)anarazel(dot)de> wrote:
> When reviewing the index prefetching patch I got a bit dismayed at how long
> pg_attribute_always_inline is due to the way it triggers pgindent to format
> stuff.

I had to significantly reorder function prototypes to avoid overly
long prototypes that had pg_attribute_always_inline. While perhaps not
strictly necessary, we shouldn't have to work around the fact that
pg_attribute_always_inline is an absurdly verbose symbol name.

> I propose that we remove the _attribute_ part of the name.

+1

--
Peter Geoghegan

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Sami Imseih 2026-04-08 21:33:00 Re: Add pg_stat_autovacuum_priority
Previous Message Peter Eisentraut 2026-04-08 21:25:02 Re: DEREF_AFTER_NULL: src/common/jsonapi.c:2529