| From: | Peter Geoghegan <pg(at)bowt(dot)ie> |
|---|---|
| To: | Teodor Sigaev <teodor(at)sigaev(dot)ru> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Postgres hackers <pgsql-hackers(at)postgresql(dot)org>, Anastasia Lubennikova <a(dot)lubennikova(at)postgrespro(dot)ru> |
| Subject: | Re: Corrupted btree index on HEAD because of covering indexes |
| Date: | 2018-04-24 17:12:28 |
| Message-ID: | CAH2-Wzk=QRA+vnL_sNxNVSYci8exQP-5gv4YOv-6xwTo480yKA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Apr 24, 2018 at 9:06 AM, Teodor Sigaev <teodor(at)sigaev(dot)ru> wrote:
> Perfect!
Thanks!
> I would like to commit it but have some suggestions:
I attach a revised version, which has changes based on your feedback.
> to improve test stability it would be better to disable autovacuum:
> ALTER TABLE bttest_multi SET (autovacuum_enabled = false)
Done.
> 2) Pls, add to test DELETE as it done in
> 6db4b49986be3fe59a1f6ba6fabf9852864efc3e
Done. I will leave it to you to decide whether or not the original
create_index.sql test can now be removed.
> 3) It's not directly connected to this patch, but allocation of
> BtreeCheckState is not needed, it could be allocated on stack.
>
> 4) Nevertheless, I suggest to use palloc0 (or memset(0)) for
> BtreeCheckState. Now several fields of that structure could be not inited.
I like the idea of using palloc0(). Done that way.
--
Peter Geoghegan
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Add-missing-and-dangling-downlink-checks-to-amche.patch | text/x-patch | 29.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2018-04-24 17:16:11 | Re: [HACKERS] Runtime Partition Pruning |
| Previous Message | Alvaro Herrera | 2018-04-24 17:10:57 | Re: [HACKERS] Runtime Partition Pruning |