Re: reporting TID/table with corruption error

From: Peter Geoghegan <pg(at)bowt(dot)ie>
To: Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com>
Cc: Andrey Borodin <x4mmm(at)yandex-team(dot)ru>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: reporting TID/table with corruption error
Date: 2021-08-19 17:57:58
Message-ID: CAH2-Wz=wiEJ85m+KoXcHw2eEuFo1zyAmnL2v+ZW6ubWq3toeRQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Aug 19, 2021 at 10:49 AM Mark Dilger
<mark(dot)dilger(at)enterprisedb(dot)com> wrote:
> There was some disagreement during the development of verify_heapam on this point. We went with the idea that the user could find and inspect the corrupt data with another tool if they had the (blockno, offnum, attnum) information. As such, it wasn't necessary to include all the data in the output.

I find that kind of dubious. By definition you're never supposed to
see any verify_heapam errors. If you do end up seeing one, it
should be exceptional -- something that you'll learn from. High
verbosity makes a lot of sense here.

--
Peter Geoghegan

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jesper Pedersen 2021-08-19 18:04:20 Re: Middleware Messages for FE/BE
Previous Message John Naylor 2021-08-19 17:49:27 Re: badly calculated width of emoji in psql