Re: pgsql: Delay commit status checks until freezing executes.

From: Peter Geoghegan <pg(at)bowt(dot)ie>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: pgsql: Delay commit status checks until freezing executes.
Date: 2023-01-11 23:32:49
Message-ID: CAH2-Wz=qH-cCyxAQdDy-qSyZ2FSSheT9bzpcc5D+X7-cxtbRUg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Wed, Jan 11, 2023 at 3:06 PM Andres Freund <andres(at)anarazel(dot)de> wrote:
> > + * We can't use TransactionIdDidAbort here because it won't treat transactions
> > + * that were in progress during a crash as aborted by now. We determine that
> > + * transactions aborted/crashed through process of elimination instead.
>
> s/by now//?

Did it that way in the commit I pushed just now.

Thanks
--
Peter Geoghegan

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2023-01-11 23:51:52 pgsql: Add support for tab completion after ALTER EXTENSION ADD|DROP in
Previous Message Peter Geoghegan 2023-01-11 23:32:16 pgsql: Improve TransactionIdDidAbort() documentation.

Browse pgsql-hackers by date

  From Date Subject
Next Message Jeff Davis 2023-01-11 23:43:48 Re: Rework of collation code, extensibility
Previous Message Nathan Bossart 2023-01-11 23:26:45 Re: low wal_retrieve_retry_interval causes missed signals on Windows