Re: pgsql: Harmonize reorderbuffer parameter names.

From: Peter Geoghegan <pg(at)bowt(dot)ie>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Harmonize reorderbuffer parameter names.
Date: 2022-09-18 21:34:46
Message-ID: CAH2-Wz=kT3AWORewCA8wB8G3=zghdoVV6QjcPjnTTFxT9mEdjA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Sun, Sep 18, 2022 at 2:14 PM Peter Geoghegan <pg(at)bowt(dot)ie> wrote:
> One further caveat here is that I seem to need to set "IgnoreMacros:
> false" to get perfect results for the "inconsistent" check when the C
> preprocessor is involved, as it often is (e.g., with TransactionId
> params).

Actually that explanation is wrong. In any case trial and error has
shown that "IgnoreMacros=false" [1] and "Strict=true" produce the most
useful results.

[1] https://releases.llvm.org/14.0.0/tools/clang/tools/extra/docs/clang-tidy/checks/readability-inconsistent-declaration-parameter-name.html#cmdoption-arg-IgnoreMacros

--
Peter Geoghegan

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message John Naylor 2022-09-19 04:39:39 pgsql: Fix typos referring to PGPROC
Previous Message Peter Geoghegan 2022-09-18 21:14:06 Re: pgsql: Harmonize reorderbuffer parameter names.