Re: pgsql: pg_regress: Don't use absolute paths for the diff

From: Peter Geoghegan <pg(at)bowt(dot)ie>
To: Peter Eisentraut <peter(at)eisentraut(dot)org>
Cc: pgsql-committers <pgsql-committers(at)lists(dot)postgresql(dot)org>
Subject: Re: pgsql: pg_regress: Don't use absolute paths for the diff
Date: 2019-02-22 23:18:51
Message-ID: CAH2-Wz=ZaVxsQSiUJYULckMZcRdbAnP61EF=bkTK=KZMc4bBwg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Thu, Feb 21, 2019 at 10:01 AM Peter Eisentraut <peter(at)eisentraut(dot)org> wrote:
> pg_regress: Don't use absolute paths for the diff
>
> Don't expand inputfile and outputfile to absolute paths globally, just
> where needed. In particular, pass them as is to the file name
> arguments of the diff command, so that we don't see the full absolute
> path in the diff header, which makes the diff unnecessarily verbose
> and harder to read.

This broke some of my tooling for quickly reconciling expected and
actual test outputs from my text editor.

I don't think that this was a great idea.

--
Peter Geoghegan

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2019-02-22 23:20:42 pgsql: Add TAP tests for 2PC post-commit callbacks of multixacts at rec
Previous Message Tom Lane 2019-02-22 17:23:47 pgsql: Fix plan created for inherited UPDATE/DELETE with all tables exc