| From: | Peter Geoghegan <pg(at)bowt(dot)ie> |
|---|---|
| To: | Melanie Plageman <melanieplageman(at)gmail(dot)com> |
| Cc: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, vignesh C <vignesh21(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Subject: | Re: Confine vacuum skip logic to lazy_scan_skip |
| Date: | 2024-03-08 16:06:56 |
| Message-ID: | CAH2-Wz=VrR8ihNPcnR_c-sHSbmgugo0wD1JbRF9nSkXBWmsDnA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Mar 8, 2024 at 11:00 AM Peter Geoghegan <pg(at)bowt(dot)ie> wrote:
> Seems like it might be possible to simplify/consolidate the VM-setting
> code that's now located at the end of lazy_scan_prune. Perhaps the two
> distinct blocks that call visibilitymap_set() could be combined into
> one.
FWIW I think that my error here might have had something to do with
hallucinating that the code already did things that way.
At the time this went in, I was working on a patchset that did things
this way (more or less). It broke the dependency on
all_visible_according_to_vm entirely, which simplified the
set-and-check-VM code that's now at the end of lazy_scan_prune.
Not sure how practical it'd be to do something like that now (not
offhand), but something to consider.
--
Peter Geoghegan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2024-03-08 16:07:33 | Re: Confine vacuum skip logic to lazy_scan_skip |
| Previous Message | Tristan Partin | 2024-03-08 16:05:27 | Re: meson: Specify -Wformat as a common warning flag for extensions |