From: | Peter Geoghegan <pg(at)bowt(dot)ie> |
---|---|
To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, pgsql-committers <pgsql-committers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: pgsql: Add pgindent commit to git-blame-ignore-revs file. |
Date: | 2021-06-28 16:50:35 |
Message-ID: | CAH2-Wz=U+sV_WDaatgYBxR4Oxo5KdwaJvCE_-+zgafRZoESh9w@mail.gmail.com |
Views: | Whole Thread | Raw Message | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
On Mon, Jun 28, 2021 at 9:43 AM Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
> ... and now that I look at running that command, I notice that the date
> format it generates for me is different from what it did for you:
This is because our global git configs differ.
> Is it worth documenting whatever is causing the output to be this?
> I'm sure many of us would be bothered if the date format was not always
> the same in future entries.
I handled this in passing by making the instructions specify
"--date=iso", just for consistency. It's now:
git log --pretty=format:"%H # %cd %n# %s" $PGINDENTGITHASH -1 --date=iso
This shows the pgindent-commit author's timestamp in the author's own
timezone, plus ISO format. I believe that this addresses your concern.
I'll consider the question of changing exactly how things are
documented and hook into the release process separately, in my
response to Tom.
--
Peter Geoghegan
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2021-06-28 18:18:05 | pgsql: Don't use abort(3) in libpq's fe-print.c. |
Previous Message | Tom Lane | 2021-06-28 16:47:49 | Re: pgsql: Add pgindent commit to git-blame-ignore-revs file. |